## Feat * feat(ai): add AI suggestion engine, context gathering, and ghost text overlay (`v0.3.0`) ## Security & Perf * fix(ai): restrict background `--help` execution to a hardcoded command allowlist to prevent RCE * fix(root): defer context cancellation in goroutine to prevent resource leaks * perf(ai): implement LRU eviction and maximum size limit for `ProviderCache` * perf(ai): truncate command context output (`CommandContextProvider.Gather`) to 1000 characters to save tokens ## Bug Fixes * fix(ai): add mutex synchronization and thread-safe snapshotting to `AIEngine.RegisterProvider` and `GatherDynamicContext` * fix(ai): return a copy of fresh `Suggestion` in `AIEngine.Suggest` to prevent cache mutation * fix(ai): use length-prefixed encoding in `EnvSnapshot.Hash` to prevent delimiter collisions * fix(ai): skip variable assignment lines containing `=` when extracting Makefile targets * fix(runner): check `scanner.Err()` and return `nil` on scan errors in justfile generator * test(ci): rename `git commit` to `git checkout` in overlay test to resolve CI `typos` false positive
164 lines
4.2 KiB
Go
164 lines
4.2 KiB
Go
package tests
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/versenilvis/iris/ai"
|
|
"github.com/versenilvis/iris/spec"
|
|
)
|
|
|
|
type mockProvider struct {
|
|
name string
|
|
matchPref string
|
|
gatherRet string
|
|
calls int32
|
|
}
|
|
|
|
func (m *mockProvider) Name() string {
|
|
return m.name
|
|
}
|
|
|
|
func (m *mockProvider) Matches(buf string) bool {
|
|
return len(buf) >= len(m.matchPref) && buf[:len(m.matchPref)] == m.matchPref
|
|
}
|
|
|
|
func (m *mockProvider) Gather(ctx context.Context) (string, error) {
|
|
atomic.AddInt32(&m.calls, 1)
|
|
return m.gatherRet, nil
|
|
}
|
|
|
|
func TestProviderCache_TTL(t *testing.T) {
|
|
cache := ai.NewProviderCache(50 * time.Millisecond)
|
|
provider := &mockProvider{
|
|
name: "test-prov",
|
|
matchPref: "test",
|
|
gatherRet: "cached-data",
|
|
}
|
|
ctx := context.Background()
|
|
|
|
// call 1 -> should gather
|
|
res1 := cache.GetOrGather(ctx, provider)
|
|
if res1 != "cached-data" || atomic.LoadInt32(&provider.calls) != 1 {
|
|
t.Fatalf("expected gather call 1, got res: %q, calls: %d", res1, provider.calls)
|
|
}
|
|
|
|
// call 2 immediately -> should hit cache
|
|
res2 := cache.GetOrGather(ctx, provider)
|
|
if res2 != "cached-data" || atomic.LoadInt32(&provider.calls) != 1 {
|
|
t.Fatalf("expected cache hit (calls stay 1), got calls: %d", provider.calls)
|
|
}
|
|
|
|
// wait for ttl to expire
|
|
time.Sleep(60 * time.Millisecond)
|
|
|
|
// call 3 after ttl -> should gather again
|
|
res3 := cache.GetOrGather(ctx, provider)
|
|
if res3 != "cached-data" || atomic.LoadInt32(&provider.calls) != 2 {
|
|
t.Fatalf("expected gather call 2 after ttl, got calls: %d", provider.calls)
|
|
}
|
|
}
|
|
|
|
func TestAIEngine_DynamicContext(t *testing.T) {
|
|
provider := &mockProvider{
|
|
name: "docker-mock",
|
|
matchPref: "docker exec",
|
|
gatherRet: "test-container\tnginx",
|
|
}
|
|
|
|
engine := ai.NewAIEngine(func(ctx context.Context, buf string, env ai.EnvSnapshot, dynamicCtx string) (*spec.Suggestion, error) {
|
|
if dynamicCtx != "test-container\tnginx" {
|
|
t.Fatalf("expected dynamicCtx to be passed to handler, got: %q", dynamicCtx)
|
|
}
|
|
return &spec.Suggestion{Cmd: "docker exec -it test-container bash", Confidence: 85}, nil
|
|
})
|
|
engine.RegisterProvider(provider)
|
|
|
|
ctx := context.Background()
|
|
sugg, err := engine.Suggest(ctx, "docker exec ", ai.EnvSnapshot{}, "")
|
|
if err != nil || sugg == nil {
|
|
t.Fatalf("expected suggestion, got err: %v, sugg: %+v", err, sugg)
|
|
}
|
|
if sugg.Cmd != "docker exec -it test-container bash" {
|
|
t.Fatalf("unexpected cmd: %q", sugg.Cmd)
|
|
}
|
|
}
|
|
|
|
// Verify that cache evicts expired entries and resets when exceeding 50 items to prevent unbounded memory growth
|
|
func TestProviderCache_Eviction(t *testing.T) {
|
|
cache := ai.NewProviderCache(10 * time.Millisecond)
|
|
ctx := context.Background()
|
|
|
|
for i := 0; i < 55; i++ {
|
|
p := &mockProvider{
|
|
name: fmt.Sprintf("prov-%d", i),
|
|
matchPref: "test",
|
|
gatherRet: "data",
|
|
}
|
|
cache.GetOrGather(ctx, p)
|
|
}
|
|
|
|
time.Sleep(20 * time.Millisecond)
|
|
|
|
pNext := &mockProvider{
|
|
name: "prov-next",
|
|
matchPref: "test",
|
|
gatherRet: "data",
|
|
}
|
|
cache.GetOrGather(ctx, pNext)
|
|
}
|
|
|
|
// Verify that CommandContextProvider caps gathered output to 1000 characters to protect token budget
|
|
func TestCommandContextProvider_Truncation(t *testing.T) {
|
|
provider := &ai.CommandContextProvider{
|
|
NameStr: "test-trunc",
|
|
Prefixes: []string{"echo"},
|
|
GatherCmd: []string{"go", "env"},
|
|
Label: "GoEnv",
|
|
}
|
|
ctx := context.Background()
|
|
res, err := provider.Gather(ctx)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %v", err)
|
|
}
|
|
if !strings.Contains(res, "GoEnv:\n") {
|
|
t.Fatalf("expected label prefix, got: %q", res)
|
|
}
|
|
if len(res) > 1100 {
|
|
t.Fatalf("expected gathered output to be truncated around 1000 characters, got len: %d", len(res))
|
|
}
|
|
}
|
|
|
|
// Verify that concurrent provider registration and context gathering do not cause data races
|
|
func TestAIEngine_ConcurrentRegistrationAndGather(t *testing.T) {
|
|
engine := ai.NewAIEngine(nil)
|
|
ctx := context.Background()
|
|
var wg sync.WaitGroup
|
|
|
|
for i := 0; i < 50; i++ {
|
|
wg.Add(1)
|
|
go func(idx int) {
|
|
defer wg.Done()
|
|
p := &mockProvider{
|
|
name: fmt.Sprintf("conc-prov-%d", idx),
|
|
matchPref: "docker",
|
|
gatherRet: "conc-data",
|
|
}
|
|
engine.RegisterProvider(p)
|
|
}(i)
|
|
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
engine.GatherDynamicContext(ctx, "docker ps", "/tmp")
|
|
}()
|
|
}
|
|
|
|
wg.Wait()
|
|
}
|